jinhongyii commented on pull request #9341: URL: https://github.com/apache/tvm/pull/9341#issuecomment-949269726
@masahi 1. storage_rewrite can't handle storage scope with tag, and shared.dyn has tag 2. storage_rewrite can't handle buffer with different dtypes 3. storage_rewrite can't allocate a buffer in the place of another 2 buffers. For example, you can take a look at https://github.com/jinhongyii/tvm/blob/dyn-shared-mem/tests/python/unittest/test_tir_transform_merge_dynamic_shared_memory_allocations.py#L80-L104 C_sh's allocation reuses the memory of A_sh **and** B_sh. However, if we use the original algorithm of storage rewrite, it can only allocate C_sh in the place of A_sh **or** B_sh. The result allocation size would be block * block * 6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
