ashutosh-arm commented on a change in pull request #9338:
URL: https://github.com/apache/tvm/pull/9338#discussion_r734420148



##########
File path: tests/cpp/relay/backend/contrib/cmsisnn/compiler_attrs_test.cc
##########
@@ -0,0 +1,125 @@
+/*

Review comment:
       The generated api does not change, but context buffer size might change 
based on the flags supplied. For a particular combination of network params, we 
could check on the buffer size in the tvmc output? or is it too much testing? 
:thinking: 
   
   Another thing is how are we going to check that the output for variety of 
combinations of mattrs is correct? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to