Mousius commented on a change in pull request #9323:
URL: https://github.com/apache/tvm/pull/9323#discussion_r734776847
##########
File path: tests/scripts/task_cpp_unittest.sh
##########
@@ -45,3 +45,11 @@ cd apps/bundle_deploy
rm -rf build
make test_dynamic test_static
cd ../..
+
+# Test Arm(R) Cortex(R)-M55 CPU and Ethos(TM)-U55 NPU demo app
+if test -f
"/opt/arm/FVP_Corstone_SSE-300_Ethos-U55/models/Linux64_GCC-6.4/FVP_Corstone_SSE-300_Ethos-U55"
&& pip3 list | grep vela; then
+ sudo pip3 install -e python
Review comment:
Should this not be done earlier rather than as a side effect of invoking
the unit test script?
##########
File path: apps/microtvm/ethosu/run_demo.sh
##########
@@ -79,6 +83,30 @@ while (( $# )); do
fi
;;
+ --fvp_path)
+ if [ $# -gt 1 ]
+ then
+ export PATH="$2/models/Linux64_GCC-6.4:$PATH"
Review comment:
Should this follow a similar pattern to the other arguments and export
an `FVP_PATH` ?
##########
File path: tests/scripts/task_cpp_unittest.sh
##########
@@ -45,3 +45,11 @@ cd apps/bundle_deploy
rm -rf build
make test_dynamic test_static
cd ../..
+
+# Test Arm(R) Cortex(R)-M55 CPU and Ethos(TM)-U55 NPU demo app
+if test -f
"/opt/arm/FVP_Corstone_SSE-300_Ethos-U55/models/Linux64_GCC-6.4/FVP_Corstone_SSE-300_Ethos-U55"
&& pip3 list | grep vela; then
Review comment:
It'd be good to put the path and pip check into a variable so it's
clearer what this is checking for.
##########
File path: tests/scripts/task_cpp_unittest.sh
##########
@@ -45,3 +45,11 @@ cd apps/bundle_deploy
rm -rf build
make test_dynamic test_static
cd ../..
+
+# Test Arm(R) Cortex(R)-M55 CPU and Ethos(TM)-U55 NPU demo app
+if test -f
"/opt/arm/FVP_Corstone_SSE-300_Ethos-U55/models/Linux64_GCC-6.4/FVP_Corstone_SSE-300_Ethos-U55"
&& pip3 list | grep vela; then
+ sudo pip3 install -e python
+ cd apps/microtvm/ethosu
+ ./run_demo.sh --fvp_path /opt/arm/FVP_Corstone_SSE-300_Ethos-U55
--cmake_path /opt/arm/cmake/bin/cmake
+fi
+cd ../..
Review comment:
If we don't `cd apps/microtvm/ethosu` then this will `cd ../..` out of
the tvm directory - I don't think this is desired behaviour?
##########
File path: tests/scripts/task_cpp_unittest.sh
##########
@@ -45,3 +45,11 @@ cd apps/bundle_deploy
rm -rf build
make test_dynamic test_static
cd ../..
+
+# Test Arm(R) Cortex(R)-M55 CPU and Ethos(TM)-U55 NPU demo app
+if test -f
"/opt/arm/FVP_Corstone_SSE-300_Ethos-U55/models/Linux64_GCC-6.4/FVP_Corstone_SSE-300_Ethos-U55"
&& pip3 list | grep vela; then
+ sudo pip3 install -e python
+ cd apps/microtvm/ethosu
+ ./run_demo.sh --fvp_path /opt/arm/FVP_Corstone_SSE-300_Ethos-U55
--cmake_path /opt/arm/cmake/bin/cmake
Review comment:
This could re-use the variable suggested above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
