Mousius commented on a change in pull request #9323:
URL: https://github.com/apache/tvm/pull/9323#discussion_r735610604



##########
File path: apps/microtvm/ethosu/run_demo.sh
##########
@@ -79,6 +83,30 @@ while (( $# )); do
             fi
             ;;
 
+        --fvp_path)
+            if [ $# -gt 1 ]
+            then
+                export PATH="$2/models/Linux64_GCC-6.4:$PATH"

Review comment:
       Doesn't that mean the default value for `FVP` should be 
`FVP_Corstone_SSE-300_Ethos-U55` and then overridden here?  Creating a custom 
`PATH` inside the demo script seems overkill here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to