manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r736334994
########## File path: src/relay/backend/contrib/cmsisnn/generate_constants.cc ########## @@ -0,0 +1,230 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include <tvm/relay/attrs/nn.h> +#include <tvm/relay/attrs/transform.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/transform.h> +#include <tvm/runtime/ndarray.h> + +#include "../../../qnn/utils.h" +#include "../../../transforms/pattern_utils.h" + +namespace tvm { +namespace relay { +Expr MakeTranspose(Expr data, Array<Integer> axes); +namespace contrib { +namespace cmsisnn { + +class GenerateConstantsMutator : public MixedModeMutator { + public: + explicit GenerateConstantsMutator(IRModule& mod) : mod_(mod) {} + + private: + /*! * \brief Converts Kernel layout from HWIO to OHWI to align to CMSIS-NN requirements */ + Expr ConvertKernelLayout(Expr kernel_expr, const Conv2DAttrs* conv2d_attrs, Attrs* new_attrs) { + auto attrs = make_object<Conv2DAttrs>(); + attrs->strides = std::move(conv2d_attrs->strides); + attrs->padding = std::move(conv2d_attrs->padding); + attrs->dilation = std::move(conv2d_attrs->dilation); + attrs->groups = conv2d_attrs->groups; + attrs->channels = std::move(conv2d_attrs->channels); + attrs->kernel_size = std::move(conv2d_attrs->kernel_size); + attrs->data_layout = std::move(conv2d_attrs->data_layout); + attrs->kernel_layout = runtime::String("OHWI"); + attrs->out_layout = std::move(conv2d_attrs->out_layout); + attrs->out_dtype = std::move(conv2d_attrs->out_dtype); + *new_attrs = tvm::Attrs{attrs}; + + IRModule kernel_module; + auto func_body = MakeTranspose(kernel_expr, {Integer(3), Integer(0), Integer(1), Integer(2)}); + auto kernel_func = + Function(FreeVars(func_body), func_body, Type(), FreeTypeVars(func_body, kernel_module)); + GlobalVar kernel_var("main"); + kernel_module->Add(kernel_var, kernel_func); + kernel_module = relay::transform::FoldConstant()(kernel_module); + kernel_func = Downcast<Function>(kernel_module->Lookup("main")); + return kernel_func->body; + } + + /*! * \brief Performs weight transpose and substitutes existing constants in the composite + * function for Conv2D with CMSIS-NN Requantize constants */ + Expr GenerateConv2dRequantConstants(const Expr& expr) { + const CallNode* clip_call = nullptr; + const CallNode* requantize_call = nullptr; + const CallNode* bias_add_call = nullptr; + const CallNode* conv2d_call = nullptr; + auto* final_call = expr.as<CallNode>(); + auto* final_op = final_call->op.as<OpNode>(); + if (final_op->name == "clip") { + clip_call = final_call; + requantize_call = clip_call->args[0].as<CallNode>(); Review comment: As I said its just stylistic, so feel free to ignore it :) . Personally, I thought the ObjectRef is sufficient and no need to access the Node. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
