tqchen commented on a change in pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#discussion_r736952615
##########
File path: include/tvm/arith/int_set.h
##########
@@ -249,12 +249,20 @@ IntSet UnionLowerBound(const Array<IntSet>& sets);
Array<IntSet> UnionRegionLowerBound(const Array<Array<IntSet>>& nd_int_sets);
/*!
- * \brief Create an union set of all sets
+ * \brief Create an intersected set of all sets
* \param sets The sets to be intersected
* \return the set after intersected
*/
IntSet Intersect(const Array<IntSet>& sets);
+/*!
+ * \brief Create a difference set of two sets, possibly relaxed
+ * \param a The first set.
+ * \param b The second set.
Review comment:
Difference may not be sound here, mainly because both a and b are
relaxed, as a result the difference is no longer relax. We might need ways to
think about exact analysis in these cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
