areusch commented on a change in pull request #9212:
URL: https://github.com/apache/tvm/pull/9212#discussion_r738565613
##########
File path: python/tvm/rpc/server_ios_launcher.py
##########
@@ -99,40 +99,52 @@ def get_device_uid(target_device: Dict) -> AnyStr:
return target_device["udid"]
+def check_call_with_runtime_error(cmd: AnyStr, error_message: AnyStr) -> None:
+ """Calling the function `subprocess.check_call` and catching its possible
thrown exception."""
+
+ try:
+ subprocess.check_call(cmd.split(" "))
Review comment:
not necessary to block this PR, but one nit: i think cmd can also be a
string--is the split necessary? asking because technically you should split it
according to shell lexing rules (i.e. with shlex.split). alternatively, may be
cleaner to just pass args as a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
