tkonolige commented on a change in pull request #9299:
URL: https://github.com/apache/tvm/pull/9299#discussion_r738725497



##########
File path: src/relay/op/contrib/ethosu/depthwise.cc
##########
@@ -126,7 +126,7 @@ bool EthosuDepthwiseConv2DRel(const Array<Type>& types, int 
num_inputs, const At
   ICHECK(ifm->dtype == DataType::UInt(8) || ifm->dtype == DataType::Int(8))
       << "Expected ethosu_depthwise_conv2d type(uint8) or type(int8) for ifm 
but was "
       << ifm->dtype;
-  ICHECK(weight->dtype == DataType::UInt(8) || ifm->dtype == DataType::Int(8))
+  ICHECK(weight->dtype == DataType::UInt(8) || weight->dtype == 
DataType::Int(8))

Review comment:
       Please use the diagnostic context to report these errors. Here is an 
example: https://github.com/apache/tvm/blob/main/src/relay/op/nn/nn.cc#L65-L68.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to