tqchen edited a comment on pull request #9313: URL: https://github.com/apache/tvm/pull/9313#issuecomment-955732036
Some additional discussion pointer for later. This PR introduces a CompilationOption class which do not necessarily ties into SEScope, but needed for followup build refactor i assume. Independent from the PR It would be great to followup with a discussion on how target dependent configurations are being populated. There are two styles in general: - A0: rely on most configs in PassContext and IRModule attachment(target constraint of each functions). - A1: centralize options in a single structure and use it through out the compilation We will need to think about strategies in A0 and A1 and how do they interact with each other. If we are building a fixed function, closed box toolkit, then A1 is usually sufficient. In our case, to enable open box philosophy, we need to consider cases where constraints are pre-populated by passes (e.g. BYOC to CUDA that only works for cuda), and iterative refinement over the process. So there is a motivation for IRModule to be self-sufficient for constraints that are already populated(by previous passes), and make followup build function respect them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
