ashutosh-arm commented on a change in pull request #9397:
URL: https://github.com/apache/tvm/pull/9397#discussion_r740108140
##########
File path: src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
##########
@@ -33,29 +34,46 @@ namespace relay {
namespace contrib {
namespace cmsisnn {
-class RelayToTIRVisitor : public MixedModeVisitor {
+class RelayToTIRVisitor : public MixedModeMutator {
Review comment:
Should it be renamed RelayToTIRVisitor --> RelayToTIRMutator?
##########
File path: src/relay/backend/contrib/cmsisnn/tir_to_runtime.cc
##########
@@ -25,114 +25,50 @@
#include "../../../../runtime/file_utils.h"
#include "../../../../target/source/codegen_c.h"
+#include "../../../../target/source/codegen_c_host.h"
namespace tvm {
-namespace codegen {
-
using namespace tir;
+namespace relay {
+namespace contrib {
+namespace cmsisnn {
-class CodeGenCMSISNN : public CodeGenC {
+class CodeGenCMSISNN : public codegen::CodeGenCHost {
Review comment:
Its great that its working with CodeGenCHost now. Just looks tiny bit
odd that we are generating target code by deriving from Host codegen. But I
also want to say that I don't have any real problem if it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
