Lunderberg commented on pull request #42: URL: https://github.com/apache/tvm-rfcs/pull/42#issuecomment-957771118
From @vinx13's [suggestion on the TVM PR thread](https://github.com/apache/tvm/pull/9391#pullrequestreview-794808362), quoting here for the discussion. > Given it is common that only buffer + indices matters in rewriting, I'd suggest refactor into `RewriteBufferAccess(pair<buffer, indices>)` without modifying IR itself wherever possible. We can use a pair or auxiliary data structure `BufferAccess` (avoid potential confusion with concrete buffer pointer) to hold the input/output. We can discuss more in the RFC My concern there is for newcomers coming to the codebase. Utility functions are effective if somebody knows that the utility functions exist, but require that knowledge first. Making the preferred method to handle a specific task be the default way to do it, without requiring the utility function, is easier for somebody to find. That said, I agree that a utility function would be a good fallback if we don't want to change the TIR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
