shingjan commented on a change in pull request #9432:
URL: https://github.com/apache/tvm/pull/9432#discussion_r741449460
##########
File path: python/tvm/tir/__init__.pyi
##########
@@ -0,0 +1,612 @@
+from typing import (
Review comment:
Thanks for the prompt review! There is a discussion in which Wuwei and I
decided to put `PrimExpr` and `PrimExprWithOp` (for future use) here in
`tir/__init__.pyi` instead of `script/tir/__init__.pyi`. Therefore stubs from
`script/tir` will need to import `PrimExpr` and `IterVar` etc from `tir`. I am
curious about your take on this.
##########
File path: python/tvm/tir/__init__.pyi
##########
@@ -0,0 +1,612 @@
+from typing import (
Review comment:
Thanks for the prompt review! There is a discussion in which Wuwei and I
decided to put `PrimExpr` and `PrimExprWithOp` (for future use) here in
`tir/__init__.pyi` instead of `script/tir/__init__.pyi`. Therefore stubs from
`script/tir` will need to import `PrimExpr`, `IterVar` and etc. from `tir`. I
am curious about your take on this.
##########
File path: python/tvm/tir/__init__.pyi
##########
@@ -0,0 +1,612 @@
+from typing import (
Review comment:
this stub is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
