mbs-octoml commented on pull request #9313: URL: https://github.com/apache/tvm/pull/9313#issuecomment-959658446
A final word about the defaulting of the host device to kDLCPU for the record. I carried that logic over from the 3 existing places where target maps & host targets defaulting is done. Note that there are many places in the code which currently hard code kDLCPU in addition to this defaulting logic, the sequel will fix those to use the host's type. I disagree with this defaulting logic -- it should all go away in favor of a much clearer API. But that is a work in progress. For targets which do not have a kDLCPU host the user can make sure the host_target is always given. That will trigger a WARNING if it is not a kDLCPU just because I'm unsure if the code base will support that at the moment (no doubt there are other kDLCPU assumptions buried in there). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
