leandron commented on a change in pull request #9425:
URL: https://github.com/apache/tvm/pull/9425#discussion_r743550958



##########
File path: docker/install/ubuntu_install_rocm.sh
##########
@@ -21,10 +21,10 @@ set -u
 set -o pipefail
 
 # Install ROCm cross compilation toolchain.
-wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key 
add -
-echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > 
/etc/apt/sources.list.d/rocm.list
+wget -qO - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
+echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/4.3/ ubuntu main' | 
sudo tee /etc/apt/sources.list.d/rocm.list

Review comment:
       Interesting because I checked the current version being used, and it 
looks like it is rocm 4.3.0. That is why I proposed to use this version 
specifically:
   
   ```
   $ docker run -it --rm tlcpack/ci-gpu:v0.78 bash
   root@488adea49541:/# dpkg -l | grep rocm
   ii  rocm-clang-ocl                        0.5.0.40300-52                     
                              amd64        OpenCL compilation with clang 
compiler.
   ii  rocm-cmake                            0.5.0.40300-52                     
                              amd64        rocm-cmake built using CMake
   ii  rocm-dbgapi                           0.48.0.40300-52                    
                              amd64        Library to provide AMD GPU debugger 
API
   ii  rocm-debug-agent                      2.0.1.40300-52                     
                              amd64        Radeon Open Compute Debug Agent 
(ROCdebug-agent)
   ii  rocm-dev                              4.3.0.40300-52                     
                              amd64        Radeon Open Compute (ROCm) Runtime 
software stack
   ii  rocm-device-libs                      1.0.0.40300-52                     
                              amd64        Radeon Open Compute - device 
libraries
   ii  rocm-gdb                              10.2.40300-52                      
                              amd64        ROCgdb
   ii  rocm-opencl                           2.0.0.40300-52                     
                              amd64        OpenCL: Open Computing Language on 
ROCclr
   ii  rocm-opencl-dev                       2.0.0.40300-52                     
                              amd64        OpenCL: Open Computing Language on 
ROCclr
   ii  rocm-smi-lib                          4.0.0.40300-52                     
                              amd64        AMD System Management libraries
   ii  rocm-utils                            4.3.0.40300-52                     
                              amd64        Radeon Open Compute (ROCm) Runtime 
software stack
   ii  rocminfo                              1.0.0.40300-52                     
                              amd64        Radeon Open Compute (ROCm) Runtime 
rocminfo tool
   root@488adea49541:/# 
   ```
   
   I'm not very familiar with ROCm in general, so can you have a look and see 
what's best for us to do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to