adstraw commented on a change in pull request #9473: URL: https://github.com/apache/tvm/pull/9473#discussion_r745152878
########## File path: tests/python/contrib/test_hexagon/conftest.py ########## @@ -1,37 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -""" Hexagon testing fixtures used to deduce testing argument - values from testing parameters """ - -import tvm -from .infrastructure import get_packed_filter_layout - - [email protected] -def shape_nhwc(batch, in_channel, in_size): - return (batch, in_size, in_size, in_channel) - - [email protected] -def shape_oihw(out_channel, in_channel, kernel): - return (out_channel, in_channel, kernel, kernel) - - [email protected] -def shape_oihw8i32o4i(out_channel, in_channel, kernel): - return get_packed_filter_layout(out_channel, in_channel, kernel, kernel) Review comment: I removed the fixtures because of their effect in terms of the ordering of parameters on the pytest command lines which I personally find confusing. I just realized, though, that the maxpool test in this same directory relies on these fixtures so I either need to remove that dependence or add back these fixtures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
