lhutton1 commented on a change in pull request #9442: URL: https://github.com/apache/tvm/pull/9442#discussion_r745672194
########## File path: src/relay/op/contrib/ethosu/binary_elementwise.cc ########## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file src/relay/op/contrib/ethosu/binary_elementwise.cc + * \brief Binary elementwise operators definitions for the Arm(R) Ethos(TM)-U NPU. + */ +#include <tvm/relay/op.h> + +#include "common.h" + +namespace tvm { +namespace relay { +namespace op { +namespace contrib { +namespace ethosu { + +/*! \brief Attributes used by the Ethos(TM)-U NPU binary elementwise operators */ +struct EthosuBinaryElementwiseAttrs : public tvm::AttrsNode<EthosuBinaryElementwiseAttrs> { + String operator_type; + double ifm_scale; + int ifm_zero_point; + double ifm2_scale; + int ifm2_zero_point; + double ofm_scale; + int ofm_zero_point; + IndexExpr ofm_channels; + bool reversed_operands; + String activation; + int clip_min; + int clip_max; + String ifm_layout; + String ifm2_layout; + String ofm_layout; + String ofm_dtype; + + TVM_DECLARE_ATTRS(EthosuBinaryElementwiseAttrs, "relay.attrs.EthosuBinaryElementwiseAttrs") { + TVM_ATTR_FIELD(operator_type) + .describe( + "The type of the binary elementwise operator." + "'ADD'" + "'SUB'" + "'MUL'" + "'MIN'" + "'MAX'" + "'SHR'" + "'SHL'"); + TVM_ATTR_FIELD(ifm_scale).describe("The quantization scale for the Input Feature Map tensor."); + TVM_ATTR_FIELD(ifm_zero_point) + .describe("The quantization zero point for the Input Feature Map tensor."); + TVM_ATTR_FIELD(ifm2_scale) + .describe("The quantization scale for the Input Feature Map tensor 2."); + TVM_ATTR_FIELD(ifm2_zero_point) + .describe("The quantization zero point for the Input Feature Map tensor 2."); + TVM_ATTR_FIELD(ofm_scale).describe("The quantization scale for the Output Feature Map tensor."); + TVM_ATTR_FIELD(ofm_zero_point) + .describe("The quantization zero point for the Output Feature Map tensor."); + TVM_ATTR_FIELD(ofm_channels).describe("The number of the Output Feature Map channels."); + TVM_ATTR_FIELD(reversed_operands) + .describe("True if IFM2 is the first operand and IFM is the second operand.") + .set_default(false); + TVM_ATTR_FIELD(activation) + .describe( + "The activation function to use. " + "'NONE' - no activation function. " + "'CLIP' - clip the output between clip_min and clip_max. " + "'TANH' - tanh activation function. " + "'SIGMOID' - sigmoid activation function. " + "'LUT' - use a look-up table to perform the activation function." + "Available activations for activation type:" + "{int8, uint8}: 'NONE', 'CLIP', 'TANH', 'SIGMOID', 'LUT'" + "{int32}: 'NONE'") + .set_default("NONE"); + TVM_ATTR_FIELD(clip_min) + .describe("The minimum clipping value if activation = 'CLIP'.") + .set_default(0); + TVM_ATTR_FIELD(clip_max) + .describe("The maximum clipping value if activation = 'CLIP'.") + .set_default(0); + TVM_ATTR_FIELD(ifm_layout) + .describe("The layout of the Input Feature Map tensor. Can be 'NHWC' or 'NHCWB16'.") + .set_default("NHWC"); + TVM_ATTR_FIELD(ifm2_layout) + .describe("The layout of the Input Feature Map tensor 2. Can be 'NHWC' or 'NHCWB16'.") + .set_default("NHWC"); + TVM_ATTR_FIELD(ofm_layout) + .describe("The layout of the Output Feature Map tensor. Can be 'NHWC' or 'NHCWB16'.") + .set_default("NHWC"); + TVM_ATTR_FIELD(ofm_dtype) + .describe( + "The Output Feature Map tensor type." + "MUL, ADD, SUB {IFM}->{OFM}:" + " {uint8, int8 int32} -> {uint8, int8, int32}, any pairing" + "MAX, MIN:" + " IFM and OFM must be of the same type, one of:" + " {int8, uint8}" + "SHR {IFM}->{OFM}:" + " {int32}->{int8, uint8, int32}, any pairing" + "SHL:" + " {int32}->{int32} only") + .set_default("NHWC"); Review comment: Apologies missed this in my first pass, ```suggestion .set_default("int8"); ``` If `int8` is a suitable default value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
