gromero commented on a change in pull request #9229:
URL: https://github.com/apache/tvm/pull/9229#discussion_r746190697



##########
File path: include/tvm/runtime/device_api.h
##########
@@ -268,6 +268,8 @@ inline const char* DeviceName(int type) {
       return "webgpu";
     case kDLHexagon:
       return "hexagon";
+    case 129:

Review comment:
       yeah, sorry, I left it while the PR is in Draft state. I'll need to fix 
it in a follow-on PR tho (I still need to figure out what's exactly missing - 
fwiw it seems that `module.benchmark()` and so `module.time_evaluator` works 
fine on micro targets with that change hence it seems not much is missing to 
make it work the right way). For now I can add `--print-time` to the list of 
non-supported options for micro targets on `tvmc run`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to