mshr-h commented on a change in pull request #9060:
URL: https://github.com/apache/tvm/pull/9060#discussion_r746330230
##########
File path: docker/install/ubuntu_install_caffe.sh
##########
@@ -22,13 +22,40 @@ set -o pipefail
apt-get update --fix-missing
-# The precompiled caffe dependents on tzdata.
-# While installing tzdata in docker, we need set the time zone manually,
-# which will cause the container to hang during installation.
-# So in order to avoid manually selecting the time zone, set as following:
-export DEBIAN_FRONTEND=noninteractive
-apt-get install -y tzdata
+# Install dependencies
+apt-get install -y --no-install-recommends libboost-filesystem-dev
libboost-python-dev \
+ libboost-system-dev libboost-thread-dev libboost-regex-dev
protobuf-compiler \
+ libprotobuf-dev libhdf5-serial-dev libopenblas-dev libgflags-dev
libgoogle-glog-dev
+rm -rf /var/lib/apt/lists/*
Review comment:
That's just a best practice for Dockerfiles.
[Best practices for writing Dockerfiles | Docker
Documentation](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run)
It might be unnecessary for this script. I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
