mbs-octoml commented on a change in pull request #9326:
URL: https://github.com/apache/tvm/pull/9326#discussion_r746725199
##########
File path: src/relay/backend/build_module.cc
##########
@@ -207,7 +210,7 @@ class RelayBuildModule : public runtime::ModuleNode {
} else if (name == "optimize") {
return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) {
ICHECK_EQ(args.num_args, 2);
- *rv = this->Optimize(args[0], args[1], this->params_);
Review comment:
The code was using both local and member params simultaneousy, but the
local was only ever bound to the member anyway. So I just got rid of the local.
Note there's some weirdness in this API as to what state is expected to come
over between 'build' and 'optimize'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
