electriclilies commented on a change in pull request #9479:
URL: https://github.com/apache/tvm/pull/9479#discussion_r747074829
##########
File path: src/relay/op/op_common.h
##########
@@ -60,6 +60,7 @@ namespace relay {
.add_type_rel("Identity", IdentityRel)
\
.set_attr<TOpPattern>("TOpPattern", kElemWise)
\
.set_attr<TOpIsStateful>("TOpIsStateful", false)
\
+ .set_attr<CommutativeOp>("CommutativeOp", false)
\
Review comment:
Do we need to put the commutativity property on unary and ops with 3+
arity?
I guess the downside is that then you'd need to check that arity == 2 before
looking at the CommutativeOp attribute, or that the CommutativeOp attr is
actually on the op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
