jtuyls commented on a change in pull request #9336:
URL: https://github.com/apache/tvm/pull/9336#discussion_r747362113
##########
File path: tests/python/contrib/test_vitis_ai/test_vitis_ai_codegen.py
##########
@@ -241,6 +240,13 @@ def test_upsampling(dpu_target):
verify_codegen(mod, dpu_target=dpu_target)
[email protected](
+ reason="I and O used to be mixed up in kernel layouts in TVM."
+ "This is fixed, but vitis needs to adopt the new convention."
+ "To change, simply remove this line:"
+
"https://github.com/Xilinx/pyxir/blob/bef661d6d77adcdbd2cf4163f2cf3a1d31d40406/";
+ "python/pyxir/frontend/tvm/relay_tools/relay_l2_convolution.py#L380"
+)
Review comment:
Thanks, this kernel layout switch makes a lot of sense to me. I will fix
this in the Vitis flow and then we can remove skipping the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
