manupa-arm commented on pull request #9331: URL: https://github.com/apache/tvm/pull/9331#issuecomment-966204840
> if you genuinely disagree feel free to merge without test coverage My position is to keep the assert (as originally added by @ashutosh-arm -- not a request for a change). I only oppose removing it on the basis it is not tested. Im happy to do it in a follow up if thats what @ashutosh-arm wants to do here ? > his has happened on other PRs I've reviewed. Hence the questioning here, because this exact point is questioned elsewhere but not here. Other places we committed to follow up if that is direction we want to take. cc : @ekalda @mbaret. Im pretty sure if we agree on this point we will do the necessary changes. > working on the assumption we want the code to continue working for the forsee-able future Im pretty sure we all want this -- just being lenient on internal asserts -- that is all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
