manupa-arm commented on a change in pull request #9500:
URL: https://github.com/apache/tvm/pull/9500#discussion_r749376925
##########
File path: python/tvm/relay/build_module.py
##########
@@ -102,6 +102,7 @@ def __init__(self):
self._get_params_func = self.mod["get_params"]
self._get_function_metadata = self.mod["get_function_metadata"]
self._get_devices = self.mod["get_devices"]
+ self._get_irmodule = self.mod["get_irmodule"]
Review comment:
I see; I thought we are implementing that in this PR.
##########
File path: python/tvm/relay/build_module.py
##########
@@ -376,10 +381,11 @@ def build(ir_mod, target=None, target_host=None,
params=None, mod_name="default"
)
func_metadata = bld_mod.get_function_metadata()
devices = bld_mod.get_devices()
+ final_ir_mods = bld_mod.get_irmodule()
if executor == "aot":
executor_factory = _executor_factory.AOTExecutorFactoryModule(
- ir_mod, target, runtime_mod, mod_name, params, func_metadata,
devices
+ ir_mod, final_ir_mods, target, runtime_mod, mod_name, params,
func_metadata, devices
Review comment:
lowered_ir_mods ?
##########
File path: python/tvm/relay/build_module.py
##########
@@ -249,6 +250,10 @@ def get_params(self):
ret[key] = value.data
return ret
+ def get_irmodule(self):
+ """Returns the Target IRModule's from code generation"""
Review comment:
"post-lowering" seems good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
