ashutosh-arm commented on a change in pull request #9409:
URL: https://github.com/apache/tvm/pull/9409#discussion_r752142861
##########
File path: tests/python/contrib/test_cmsisnn/test_conv2d.py
##########
@@ -129,8 +128,11 @@ def make_model(
@pytest.mark.parametrize("kernel_size", [(3, 3)])
@pytest.mark.parametrize("padding", ["SAME", "VALID"])
@pytest.mark.parametrize("strides, dilation", [((2, 2), (1, 1)), ((1, 1), (1,
1))])
[email protected]("enable_bias", [True, False])
@pytest.mark.parametrize("relu_type", ["NONE", "RELU"])
[email protected](
+ "conv_type, depth_multiplier, enable_bias",
+ [("conv2d", 1, True), ("conv2d", 1, False), ("depthwise", 1, True),
("depthwise", 3, True)],
Review comment:
The problem is depth_multipler has to be 1 in Conv2D. Depthwise support
1 and non-1 depth multipliers both. Earlier I'd kept it as a separate parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
