abhikran-quic edited a comment on pull request #9186: URL: https://github.com/apache/tvm/pull/9186#issuecomment-974769683
> @abhikran-quic https://github.com/apache/tvm/pull/9540/files should fix this. You can take these changes in this PR and I can close mine. Thank you @AndrewZhaoLuo for your help on this. I've incorporated the changes mentioned by you in the latest patch. However, there's one more pending issue. After removing test_matmulinteger from unsupported_onnx_tests, I saw an error from [onnx.py](https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/onnx.py#L4557) . Here is the link to [CI](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9186/10/pipeline/) where failure is seen. IMHO, when we remove test_matmulinteger the error is expected because there is no op named matmulinteger in onnx.py. Onnxruntime supports [MatMulInteger16 ](https://github.com/microsoft/onnxruntime/blob/master/docs/ContribOperators.md#com.microsoft.MatMulInteger16) and [MatMulIntegerToFloat](https://github.com/microsoft/onnxruntime/blob/master/docs/ContribOperators.md#com.microsoft.MatMulIntegerToFloat) and hence we can add ops with the names mentioned in Onnx runtime documentation. Hence, removing test_matmulinteger is leading to the error. In my latest patch, I've retained test_matmulinteger in unsupported_onnx_tests. Please share your thoughts on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
