shingjan commented on a change in pull request #9505:
URL: https://github.com/apache/tvm/pull/9505#discussion_r754009189
##########
File path: tests/python/unittest/test_tvmscript_type.py
##########
@@ -173,7 +173,7 @@ def different_access_indices(a: T.handle, b: T.handle) ->
None:
]
)
with T.init():
- B[vj, vi] = T.exp(B[vi, vj])
+ B[vj, vi] = T.exp(B[vj, vi], dtype="float32")
Review comment:
If we do need to set a default dtype for intrinsics defined outside of
`script/tir/intrinsic`, like `exp` here defined in `tir/op`, is `float32`
reasonable here? We could do something like
```def exp(x: PrimExpr, dtype: str = "float32") -> PrimExpr: ...```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
