electriclilies commented on a change in pull request #9569:
URL: https://github.com/apache/tvm/pull/9569#discussion_r755544735
##########
File path: src/relay/transforms/partial_eval.cc
##########
@@ -615,6 +615,8 @@ class PartialEvaluator : public ExprFunctor<PStatic(const
Expr& e, LetList* ll)>
value.push_back(ps);
expr.push_back(ps->dynamic);
}
+ // Note: The partial evaluator seems to do some weird stuff with sharing.
Changing Tuple(expr)
+ // to WithFields(op, expr) causes some strange failures.
return HasStatic(MkSTuple(value), ll->Push(Tuple(expr)));
Review comment:
I was seeing some failures in the partial evaluator tests, but also in
other places. I'll update the comment to clarify, I don't think I need to add
another unittest here though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
