Mousius commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r756237095
##########
File path: src/relay/op/call/call.cc
##########
@@ -95,20 +96,29 @@ RELAY_REGISTER_OP("call_lowered")
.set_attr<FInferCorrectLayout>("FInferCorrectLayout",
ElemwiseArbitraryLayout);
CallLoweredProps GetCallLoweredProps(const CallNode* call_node) {
Review comment:
Given this is such a fundamental function it seems like we should have
test cases for all the different cases it throws an exception and what we
expect as a return value. Though I equally understand this wasn't authored in
this PR.
@mbs-octoml / @electriclilies can you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
