leandron commented on pull request #9590: URL: https://github.com/apache/tvm/pull/9590#issuecomment-979479003
> Besides the comment inline, just some nits about the commit message (since you'll need to re-trigger the CI :) ): since it's a single commit, I understand that the added tag `[tvmc]` won't land when the change is merged, but I think it should, so you would need to add the tag to the commit too; Looking at the commit records we usually use tag `[TVMC]`, instead of `[tvmc]`, so I think it would be nice to stick with `[TVMC]`; there are two spaces between `one part`; s/explicit ask/explicitly ask/? Agree with all points and will improve the commit message tomorrow. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
