junrushao1994 commented on a change in pull request #9594:
URL: https://github.com/apache/tvm/pull/9594#discussion_r758060560
##########
File path: python/tvm/script/tir/__init__.pyi
##########
@@ -371,3 +372,5 @@ class handle:
def data(self: handle) -> Ptr: ...
class Ptr: ...
+
+def target(target_str: str) -> Target: ...
Review comment:
the input type is not limited to `str`, right?
##########
File path: tests/python/unittest/test_tvmscript_roundtrip.py
##########
@@ -3205,5 +3205,30 @@ def test_nontrivial_range_axis():
tvm.ir.assert_structural_equal(func, rt_func, True)
[email protected]_func
+def func_with_target_spec() -> None:
+ T.func_attr(
Review comment:
Shall we add a unittest for target tag? For example:
```
T.target("nvidia/nvidia-a100")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
