ekalda commented on a change in pull request #9576:
URL: https://github.com/apache/tvm/pull/9576#discussion_r759505793
##########
File path: python/tvm/relay/backend/contrib/ethosu/legalize.py
##########
@@ -831,6 +832,170 @@ def __call__(self, *args, **kwargs):
pass
+class MeanRewriter(DFPatternCallback):
+ """Convert ethosu.mean composite functions to to an equivalent
legalization:
+ - Case 1 (axis == [1, 2] and keepsdims == True):
+ ethosu_depthwise_conv2d + ethosu_binary_elementwise
+ - Case 2 (ifm qparams == ofm qparams): ethosu_pooling
+ - Case 3 (else): ethosu_depthwise_conv2d
+ """
+
+ def __init__(self):
+ super().__init__(require_type=True)
+ self.pattern = (
+ wildcard().has_attr({"Composite":
ethosu_patterns.MeanParams.composite_name})
+ )(wildcard())
+
+ def callback(
+ self, pre: tvm.relay.Expr, post: tvm.relay.Expr, node_map:
tvm.ir.container.Map
+ ) -> tvm.relay.Expr:
+ params = ethosu_patterns.MeanParams(post.op.body)
+ params.ifm.tensor = post.args[0]
+
+ ifm_shape = params.ifm.shape
+ ofm_shape = params.ofm.shape
+ lut = relay.const([], "int8")
+ axis = params.axis
+ reduced_op = params.ifm.tensor
+
+ # Enforce 4d input
+ if len(ifm_shape) < 4:
+ axis = [x + 1 for x in axis]
+ if len(ifm_shape) == 3:
+ ifm_shape = [1, params.height, params.width, ifm_shape[2]]
+ else:
+ ifm_shape = [1, params.height, params.width, 1]
+ reduced_op = relay.reshape(reduced_op, ifm_shape)
Review comment:
Yeah I guess it would be a rather rare case to have to do a 1D mean, so
we can do it in a separate PR in the future if there will be need for it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]