areusch commented on a change in pull request #9534:
URL: https://github.com/apache/tvm/pull/9534#discussion_r759542162
##########
File path: docs/requirements.txt
##########
@@ -0,0 +1,11 @@
+autodocsumm==0.2.7
Review comment:
rather than do this, should we add a tool to run pip freeze on ci-gpu
and then use this as a constraints file to locally install these deps? my
concern is that adding a requirements.txt with pins may drift.
##########
File path: docs/conf.py
##########
@@ -352,7 +352,7 @@ def force_gc(gallery_conf, fname):
"gallery_dirs": gallery_dirs,
"subsection_order": subsection_order,
"filename_pattern": os.environ.get("TVM_TUTORIAL_EXEC_PATTERN", ".py"),
- "find_mayavi_figures": False,
+ "image_scrapers": ("mayavi",),
Review comment:
just curious, what was the problem being solved by adding this here?
right now we're mostly worried about the Sphinx version pinned in ci-gpu, so
while I think it's good for us to support a more recent sphinx, we need to dig
ourselves out of relying on ci-gpu for all docs purposes (e.g. and use it only
when doing a full docs build including gpu-dependent galleries) before we
should think about making the docs flow work on a modern ubuntu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
