manupa-arm commented on a change in pull request #9597:
URL: https://github.com/apache/tvm/pull/9597#discussion_r759907365
##########
File path: python/tvm/relay/backend/contrib/ethosu/codegen.py
##########
@@ -80,5 +63,50 @@ def _compile(ext_func):
# that can perform scheduling based on user inputs such as
# scratch memory size.
tir_mod, params = lower_to_tir(mod["main"], copy_constants())
- cmms, encoded_constants, scratch_size =
tir_to_cs_translator.translate(tir_mod, params)
- return cmms, encoded_constants, scratch_size
+
+ for idx in params.keys():
+ params[idx] = tvm.nd.array(params[idx])
Review comment:
Seems like a stylistic choice, I would prefer to keep the current
implementation as it does not have a meaningful difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
