lhutton1 commented on a change in pull request #9626:
URL: https://github.com/apache/tvm/pull/9626#discussion_r762966862
##########
File path: src/relay/op/contrib/ethosu/binary_elementwise.cc
##########
@@ -189,11 +176,11 @@ bool EthosuBinaryElementwiseRel(const Array<Type>& types,
int num_inputs, const
return false;
}
if (ofm_dtype != DataType::UInt(8) && ofm_dtype != DataType::Int(8) &&
- ofm_dtype != DataType::Int(32)) {
+ ofm_dtype != DataType::Int(16) && ofm_dtype != DataType::Int(32)) {
reporter->GetDiagCtx().EmitFatal(
Diagnostic::Error(reporter->GetSpan())
<< "Invalid operator: expected ethosu_binary_elementwise " <<
operator_type
- << " type(uint8) or type(int8) or type(int32) for ofm but was " <<
ofm_dtype);
+ << " type(uint8), type(int8), type(int16) or type(int32) for ofm but
was " << ofm_dtype);
return false;
}
} else if (operator_type == "MIN" || operator_type == "MAX") {
Review comment:
Given that adding `int16` to MIN and MAX is not essential for this
change, I think it would be best to add as a separate patch WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
