ashutosh-arm commented on a change in pull request #9531:
URL: https://github.com/apache/tvm/pull/9531#discussion_r763221567
##########
File path: src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
##########
@@ -164,21 +156,15 @@ class RelayToTIRVisitor : public MixedModeMutator {
ToArg(dilation_w),
ToArg(dilation_h), ToArg(clip_min),
ToArg(clip_max)};
- // cmsis_nn_dims *input_dims (NHWC)
+ // layout NHWC
Array<PrimExpr> input_shape =
conv2d_call->args[0]->type_as<TensorTypeNode>()->shape;
- Array<PrimExpr> input_dims = CMSISNNDimensions(input_shape);
- // cmsis_nn_dims *filter_dims (OHWI for Conv2D and IHWO for depthwise)
+ // OHWI for Conv2D and IHWO for depthwise
Review comment:
Same as above. Maybe I should explicitly say that this is for CMSIS-NN
API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
