mehrdadh commented on a change in pull request #9631:
URL: https://github.com/apache/tvm/pull/9631#discussion_r763515670
##########
File path: apps/cpp_rpc/CMakeLists.txt
##########
@@ -43,4 +45,12 @@ target_include_directories(
PUBLIC DMLC_PATH
)
-target_link_libraries(tvm_rpc tvm_runtime)
+if (BUILD_FOR_ANDROID AND USE_HEXAGON_SDK)
+ find_hexagon_sdk_root("${USE_HEXAGON_SDK}" "${USE_HEXAGON_ARCH}")
+ link_directories(${HEXAGON_REMOTE_ROOT})
+ list(APPEND TVM_RPC_LINKER_LIBS cdsprpc log)
+endif()
Review comment:
You're absolutely right, we don't need to do that. For some reason when
I link them in `Hexagon.cmake` file with exactly the same approach,
link_directories fails to find the libraries. That's how I worked around this
but we need to fix it before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
