csullivan commented on a change in pull request #9631:
URL: https://github.com/apache/tvm/pull/9631#discussion_r764444647
##########
File path: apps/cpp_rpc/CMakeLists.txt
##########
@@ -43,4 +45,12 @@ target_include_directories(
PUBLIC DMLC_PATH
)
-target_link_libraries(tvm_rpc tvm_runtime)
+if (BUILD_FOR_ANDROID AND USE_HEXAGON_SDK)
+ find_hexagon_sdk_root("${USE_HEXAGON_SDK}" "${USE_HEXAGON_ARCH}")
+ link_directories(${HEXAGON_REMOTE_ROOT})
+ list(APPEND TVM_RPC_LINKER_LIBS cdsprpc log)
+endif()
Review comment:
I'm okay with conditionally linking against the hexagon sdk if we can't
get around this for now. There exists precedent on custom build behavior for
other sdks (opencl). Would be great to loop back and remove this in the future
if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
