kparzysz-quic commented on a change in pull request #9352:
URL: https://github.com/apache/tvm/pull/9352#discussion_r766089696
##########
File path: python/tvm/target/target.py
##########
@@ -623,27 +620,13 @@ def create_llvm_options(cpu_ver, config): # pylint:
disable=unused-argument
args = [s.replace("=", "@") for s in llvm_options.split()]
return "--llvm-options=" + ",".join(args)
- # TVM target attributes string
- def create_tvm_options(cpu_ver, config): # pylint: disable=unused-argument
Review comment:
This essentially broke the `link-params` on Hexagon. You added code to
transfer target attributes to the executor, but here you removed the target
attributes from the `hexagon` target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
