wrongtest edited a comment on pull request #9755: URL: https://github.com/apache/tvm/pull/9755#issuecomment-996377713
@vinx13 Hi, the issue is about string dict value as a clarification. The key type seems no problem. The parser already convert str to StringImm in annotations but provide the old dict (maybe a typo). For the pass, currently it assumes all dict values should be of `PrimExpr` in annotations. Did you mean we can allow some "compatible" values to convert to `PrimExpr` instead of simple downcasts? https://github.com/apache/tvm/blob/main/src/tir/transforms/flatten_buffer.cc#L99-L106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
