spectrometerHBH commented on a change in pull request #9699:
URL: https://github.com/apache/tvm/pull/9699#discussion_r772839825



##########
File path: src/arith/iter_affine_map.cc
##########
@@ -160,13 +160,22 @@ class IterMarkSplitCollector {
   }
 };
 
+/*! \brief Record form of IterMark(x, extent) + offset */
+struct IterMarkWithOffset {

Review comment:
       Is it necessary to introduce offset, since IterMark can contain an 
IterSumExpr, and IterSumExpr can already represent `iter + base`? Maybe you can 
consider utilizing this.
   
   For example, `i*8 + j*2 + k` with `1 <= j * 2 + k <= 9, i <= 10`.
   The flattened form is `i*8 + j*2 + k`.
   The normal form is `i*8 + (j*2 + k - 1) + 1`
   The iter mark contains the normal form and extent 80. We can read from the 
normal form that the offset it 1.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to