areusch commented on a change in pull request #9733:
URL: https://github.com/apache/tvm/pull/9733#discussion_r777728427
##########
File path: Jenkinsfile
##########
@@ -397,10 +390,10 @@ stage('Unit Test') {
}
}
} else {
- Utils.markStageSkippedForConditional('python3: GPU')
+ Utils.markStageSkippedForConditional('unittest: GPU')
}
},
- 'python3: CPU': {
Review comment:
i think right now, failing unit tests wouldn't cancel integration tests.
are we concerned with overburdening CI with PRs that fail unit tests? I wonder
if we should somehow cancel integration test builds if unit tests fail. we
could also just try merging and see if it's a problem, too.
##########
File path: Jenkinsfile
##########
@@ -463,11 +478,8 @@ stage('Unit Test') {
} else {
Utils.markStageSkippedForConditional('python3: arm')
}
- }
-}
-
-stage('Integration Test') {
Review comment:
however I'm not sure it's a good idea to run the frontend tests as
non-cancellable without unit tests passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
