leandron commented on a change in pull request #9817:
URL: https://github.com/apache/tvm/pull/9817#discussion_r778094126
##########
File path: python/tvm/driver/tvmc/common.py
##########
@@ -527,11 +560,44 @@ def get_pass_config_value(name, value, config_type):
parsed_value = mapping_values.get(value.lower(), None)
if parsed_value is None:
- raise TVMCException(f"Invalid value '{value}' for configuration
'{name}'. ")
+ raise TVMCException(f"Invalid value '{value}' for configuration
'{name}'.")
- if config_type == "runtime.String":
+ elif config_type == "runtime.String":
parsed_value = value
+ elif config_type == "Array":
+ if name == "tir.add_lower_pass":
Review comment:
I think as a feature it is useful and OK to have this.
Do you mind just updating the help option for `--pass-config` to reflect the
usage with `tir.add_lower_pass`?
Help option is here:
https://github.com/apache/tvm/blob/9cc1df60701d6d46577d028c211bb568225fc4f1/python/tvm/driver/tvmc/compiler.py#L89-L96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
