d-smirnov commented on pull request #9842:
URL: https://github.com/apache/tvm/pull/9842#issuecomment-1006589412


   @junrushao1994  
   NDEBUG Cannot be used due to:
   1) It switched on/off via usage of  `set(USE_RELAY_DEBUG ON)` setting but 
not by `CMAKE_BUILD_TYPE=Debug`
   2) Currently it is always set to `NDEBUG=1` as per comment in 
cmake/modules/LLVM.cmake:
   ```
    18 # LLVM rules
    19 # Due to LLVM debug symbols you can sometimes face linking issues on
    20 # certain compiler, platform combinations if you don't set NDEBUG.
    21 #
    22 # See https://github.com/imageworks/OpenShadingLanguage/issues/1069
    23 # for more discussion.
    24 add_definitions(-DDMLC_USE_FOPEN64=0 -DNDEBUG=1)
   ```
   Could you advise on this, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to