electriclilies opened a new pull request #9861: URL: https://github.com/apache/tvm/pull/9861
I propose that the JSON deserializer default fields to null. The motivation for this change is increased backwards compatibility. I need to add virtual device to the VisitAttrs of most Relay nodes. Unfortunately, this means that JSON that does not have the virtual device in it is invalid, and we have to manually add "virtual_device_": "0" to many of the nodes in JSON to get it to import correctly. After this change, if a JSON node does not contain the virtual_device_ field, it will still import the JSON correctly. By default it will set the value of the field to "0", which represents null. See the test that I added in test_json_compact.py for an example. @mbs-octoml @jroesch @tqchen @manupa-arm @areusch PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
