tqchen edited a comment on pull request #9861: URL: https://github.com/apache/tvm/pull/9861#issuecomment-1007698755
Patch up specialized handling for a particular object and key is indeed a solution to the current problem as well. One would need to think about the implication though, since the system was originally designed to support arbitrary object, and adding specializations to objects would couple the serializer with the specific object, which are supposed to grow independently(except for a few key cases like common containers). The upgrader is designed as a legacy path that separates from the main ones, with a goal to keep the overall architecture clean and separated from legacy behavior. As for the upgrader, right now we are in 0.9.dev period, and the version in the current system is `v0.9.dev0`. So likely adding the upgrading logic in a 08 to 09 upgrader can would serve the purpose. So no updates to the version is needed assuming it is an upgrade from 0.8 version to v0.9 dev cycle, and also invoke it for code . For the code that get updated during v0.9 dev period, we can also invoke it when error happens in v0.9.dev, that checks if the field exists and if not add "0"(effectively the same proposed algorithm implemented in the json_compact.py), this will cover the upgrading with the same logic without having to bump the version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
