Icemist commented on a change in pull request #9637:
URL: https://github.com/apache/tvm/pull/9637#discussion_r780872272
##########
File path: python/tvm/relay/qnn/op/qnn.py
##########
@@ -92,6 +92,44 @@ def requantize(
)
+def upward(data):
Review comment:
"I think itd also be nice to add a comment here explaining why we're
only doing this for llvm. That will help contributors decide which to apply to
new hardware."
I moved this logic to the default reqconfig. I added a little comment there.
Other cases can be handled by specified reqconfig or requantize parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
