Lunderberg commented on a change in pull request #9727:
URL: https://github.com/apache/tvm/pull/9727#discussion_r782420647
##########
File path: include/tvm/tir/buffer.h
##########
@@ -55,8 +55,48 @@ class BufferNode : public Object {
Var data;
/*! \brief data type in the content of the tensor */
DataType dtype;
- /*! \brief The shape of the buffer */
+ /*! \brief The shape of the buffer
+ *
+ * This contains the shape as it is accessed by
+ * BufferLoad/BufferStore nodes, and used by the low-level code
+ * generators.
+ */
Array<PrimExpr> shape;
+ /*! \brief The shape of the buffer prior to flattening
+ *
+ * This contains the shape as it exists prior to flattening, and is
+ * used for validating the shape of the tensor passed into the
+ * packed API.
+ *
+ * TODO(Lunderberg): Should this be a reference to the entire
Review comment:
One additional comment. The pre-flattened information is feeling less
and less like a property of the buffer, and is instead feeling like something
that should be stored in the `PrimFuncNode::buffer_map`. It doesn't represent
a difference in the computation, it is solely used to validate user input, and
it shouldn't be modified at all after flattening occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
