Mousius commented on a change in pull request #9844: URL: https://github.com/apache/tvm/pull/9844#discussion_r782829819
########## File path: docker/install/ubuntu_install_wasmtime.sh ########## @@ -0,0 +1,34 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e +set -u +set -o pipefail +set -x + + +export RUSTUP_HOME=/opt/rust +export CARGO_HOME=/opt/rust +# this rustc is one supported by the installed version of rust-sgx-sdk +curl -s -S -L https://sh.rustup.rs -sSf | sh -s -- -y --no-modify-path --profile minimal --default-toolchain stable Review comment: I think you copied the wrong bit in here as this installs Rust itself, not wasmtime ########## File path: docker/Dockerfile.ci_arm ########## @@ -48,3 +48,14 @@ RUN bash /install/ubuntu_install_redis.sh # Arm(R) Compute Library COPY install/ubuntu_download_arm_compute_lib_binaries.sh /install/ubuntu_download_arm_compute_lib_binaries.sh RUN bash /install/ubuntu_download_arm_compute_lib_binaries.sh + +# Rust env Review comment: Can we put these early as it's a pretty big stage in the Docker build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
