AndrewZhaoLuo commented on a change in pull request #9840:
URL: https://github.com/apache/tvm/pull/9840#discussion_r783664494
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -1911,6 +1911,14 @@ def convert_fully_connected(self, op):
weight_expr = self.exp_tab.new_const(weight_value,
dtype=weight_tensor_type_str)
weight_shape = _infer_shape(weight_expr)
+ # Change the output shape calculation based on keep_dim option
Review comment:
Ahh ok, can you add a test in
`tests/python/frontend/tflite/test_forward.py` in the relevant spot saying we
need to figure out how to make a tflite model with `keep_num_dims` and make a
test.
I will probably accept PR since change is fairly simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]