argrento commented on a change in pull request #9811:
URL: https://github.com/apache/tvm/pull/9811#discussion_r785907783
##########
File path: src/runtime/graph_executor/graph_executor_factory.cc
##########
@@ -57,6 +58,14 @@ PackedFunc GraphExecutorFactory::GetFunction(
return PackedFunc(
[sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv =
this->graph_json_; });
+ } else if (name == "get_graph_params") {
Review comment:
This function will return params from the compiled module (.so binary).
This is the only way to read them from the compiled module. Without this one
will not be able to read and set them with `set_params`.
Which tests will you suggest to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
